Skip to content

Apply Dag processor-specific labels to its Deployment metadata#70221

Closed
vtino17 wants to merge 2 commits into
apache:mainfrom
vtino17:fix/dag-processor-labels
Closed

Apply Dag processor-specific labels to its Deployment metadata#70221
vtino17 wants to merge 2 commits into
apache:mainfrom
vtino17:fix/dag-processor-labels

Conversation

@vtino17

@vtino17 vtino17 commented Jul 22, 2026

Copy link
Copy Markdown

The \metadata.labels\ section of the dag-processor Deployment now includes \dagProcessor.labels\ (merged with global .Values.labels), matching the pattern used by other components.

closes: #53190

The metadata.labels section of the dag-processor Deployment now
includes dagProcessor.labels (merged with global .Values.labels),
matching the pattern used by other components.

closes: apache#53190
@boring-cyborg

boring-cyborg Bot commented Jul 22, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Miretpl

Miretpl commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Could you please check discussions from previous proposed PRs for the relevant change #59290?

@Miretpl Miretpl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to block accidential merge

@vtino17

vtino17 commented Jul 22, 2026

Copy link
Copy Markdown
Author

Thanks for the pointer — I went through the discussion in #59290. Since #70205 was opened first and already covers this change with a regression test and newsfragment, I'll close this one in favor of it to avoid splitting the review. I'll follow the labels/podLabels discussion over there.

@vtino17 vtino17 closed this Jul 22, 2026
@vtino17
vtino17 deleted the fix/dag-processor-labels branch July 23, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dagProcessor in helm chart doesn't have a labels section

2 participants